pengzhiwei2018 commented on a change in pull request #3146:
URL: https://github.com/apache/hudi/pull/3146#discussion_r662712075



##########
File path: 
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/HiveSchemaUtil.java
##########
@@ -413,7 +413,12 @@ public static String generateCreateDDL(String tableName, 
MessageType storageSche
     }
 
     String partitionsStr = String.join(",", partitionFields);
-    StringBuilder sb = new StringBuilder("CREATE EXTERNAL TABLE  IF NOT EXISTS 
");
+    StringBuilder sb = new StringBuilder();
+    if (config.createManagedTable) {
+      sb.append("CREATE TABLE  IF NOT EXISTS ");
+    } else {
+      sb.append("CREATE EXTERNAL TABLE  IF NOT EXISTS ");

Review comment:
       done!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to