prashantwason commented on a change in pull request #2701:
URL: https://github.com/apache/hudi/pull/2701#discussion_r663195101
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
##########
@@ -581,14 +582,14 @@ public String getCommitActionType() {
HoodieTableMetaClient
.scanFiles(getFs(), timelinePath, path -> {
// Include only the meta files with extensions that needs to be
included
- String extension =
HoodieInstant.getTimelineFileExtension(path.getName());
+ String extension =
HoodieInstantFormat.getInstantFormat(getTimelineLayoutVersion()).getTimelineFileExtension(path.getName());
Review comment:
minor:
HoodieInstant.getFormat(getTimelineLayoutVersion) seems better than
HoodieInstantFormat.getInstantFormat(getTimelineLayoutVersion())
as the format is of the HoodieInstant and HoodieInstantFormat is an internal
implementation detail of the HoodieInstant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
