[
https://issues.apache.org/jira/browse/HUDI-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17373736#comment-17373736
]
ASF GitHub Bot commented on HUDI-1794:
--------------------------------------
hudi-bot edited a comment on pull request #2819:
URL: https://github.com/apache/hudi/pull/2819#issuecomment-861653496
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "199e377c5de50a8bce5b0af4f70d8090d714aaaa",
"status" : "CANCELED",
"url" :
"https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=183";,
"triggerID" : "199e377c5de50a8bce5b0af4f70d8090d714aaaa",
"triggerType" : "PUSH"
}, {
"hash" : "199e377c5de50a8bce5b0af4f70d8090d714aaaa",
"status" : "PENDING",
"url" :
"https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=662";,
"triggerID" : "873203870",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 199e377c5de50a8bce5b0af4f70d8090d714aaaa Azure:
[CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=183)
Azure:
[PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=662)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Generating a new instant time in HoodieActiveTimeline is not thread safe
> ------------------------------------------------------------------------
>
> Key: HUDI-1794
> URL: https://issues.apache.org/jira/browse/HUDI-1794
> Project: Apache Hudi
> Issue Type: Bug
> Reporter: Prashant Wason
> Assignee: Prashant Wason
> Priority: Major
> Labels: pull-request-available, sev:high
>
> When generating a new instant time in HoodieActiveTimeline, a static instance
> of SimpleDateFormat is used. This class is not thread safe.
> We have a production usecase where multiple HUDI datasets are processed in
> parallel in different threads of a ThreadPool. Each of these threads creates
> its own SparkRDDBackedWriteClient and calls startCommit() which generates a
> new commit time. Because SimpleDateFormat is not thread safe, we get
> corrupted instant times in several threads.
> The solution is to use a thread-specific instance of the SimpleDateFormat for
> generating new instant times.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
