[
https://issues.apache.org/jira/browse/HUDI-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17373776#comment-17373776
]
ASF GitHub Bot commented on HUDI-2042:
--------------------------------------
nsivabalan commented on a change in pull request #3108:
URL: https://github.com/apache/hudi/pull/3108#discussion_r663243700
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/model/TestOverwriteNonDefaultsWithLatestAvroPayload.java
##########
@@ -55,20 +57,23 @@ public void testActiveRecords() throws IOException {
record1.put("ts", 0L);
record1.put("_hoodie_is_deleted", false);
record1.put("city", "NY0");
+ record1.put("child", Arrays.asList("A"));
GenericRecord record2 = new GenericData.Record(schema);
record2.put("id", "2");
record2.put("partition", "");
record2.put("ts", 1L);
record2.put("_hoodie_is_deleted", false);
record2.put("city", "NY");
+ record2.put("child", Collections.emptyList());
GenericRecord record3 = new GenericData.Record(schema);
record3.put("id", "2");
record3.put("partition", "partition1");
record3.put("ts", 1L);
record3.put("_hoodie_is_deleted", false);
record3.put("city", "NY0");
+ record3.put("child", Arrays.asList("A"));
Review comment:
Can you confirm that with array data type, this test was failing if not
the fix currently given in the patch? LGTM. can land it once you confirm this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Compare the field object directly in OverwriteWithLatestAvroPayload
> -------------------------------------------------------------------
>
> Key: HUDI-2042
> URL: https://issues.apache.org/jira/browse/HUDI-2042
> Project: Apache Hudi
> Issue Type: Improvement
> Reporter: XiaoyuGeng
> Assignee: XiaoyuGeng
> Priority: Trivial
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
