[
https://issues.apache.org/jira/browse/HUDI-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17373851#comment-17373851
] ASF GitHub Bot commented on HUDI-2072: -------------------------------------- codecov-commenter edited a comment on pull request #3153: URL: https://github.com/apache/hudi/pull/3153#issuecomment-868791906 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3153?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3153](https://codecov.io/gh/apache/hudi/pull/3153?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5806a2b) into [master](https://codecov.io/gh/apache/hudi/commit/6eca06d074520140d7bc67b48bd2b9a5b76f0a87?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6eca06d) will **increase** coverage by `0.07%`. > The diff coverage is `60.71%`. [](https://codecov.io/gh/apache/hudi/pull/3153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #3153 +/- ## ============================================ + Coverage 47.51% 47.58% +0.07% - Complexity 5429 5469 +40 ============================================ Files 922 931 +9 Lines 40968 41190 +222 Branches 4105 4116 +11 ============================================ + Hits 19464 19602 +138 - Misses 19780 19862 +82 - Partials 1724 1726 +2 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `40.00% <ø> (ø)` | | | hudiclient | `35.10% <68.00%> (+0.51%)` | :arrow_up: | | hudicommon | `48.29% <0.00%> (-0.09%)` | :arrow_down: | | hudiflink | `59.91% <ø> (-0.17%)` | :arrow_down: | | hudihadoopmr | `51.29% <ø> (ø)` | | | hudisparkdatasource | `67.24% <ø> (+0.13%)` | :arrow_up: | | hudisync | `54.05% <ø> (ø)` | | | huditimelineservice | `64.07% <ø> (ø)` | | | hudiutilities | `58.05% <ø> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [.../table/action/commit/BaseCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...alidator/SqlQueryInequalityPreCommitValidator.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3ZhbGlkYXRvci9TcWxRdWVyeUluZXF1YWxpdHlQcmVDb21taXRWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [.../bootstrap/SparkBootstrapCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2Jvb3RzdHJhcC9TcGFya0Jvb3RzdHJhcENvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...table/view/HoodieTablePreCommitFileSystemView.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvSG9vZGllVGFibGVQcmVDb21taXRGaWxlU3lzdGVtVmlldy5qYXZh) | `0.00% <0.00%> (ø)` | | | [...ache/hudi/exception/HoodieValidationException.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXhjZXB0aW9uL0hvb2RpZVZhbGlkYXRpb25FeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `42.40% <20.00%> (-0.39%)` | :arrow_down: | | [.../validator/SqlQueryEqualityPreCommitValidator.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3ZhbGlkYXRvci9TcWxRdWVyeUVxdWFsaXR5UHJlQ29tbWl0VmFsaWRhdG9yLmphdmE=) | `63.63% <63.63%> (ø)` | | | [...he/hudi/config/HoodiePreCommitValidatorConfig.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVDb21taXRWYWxpZGF0b3JDb25maWcuamF2YQ==) | `67.64% <67.64%> (ø)` | | | [...idator/SqlQuerySingleResultPreCommitValidator.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3ZhbGlkYXRvci9TcWxRdWVyeVNpbmdsZVJlc3VsdFByZUNvbW1pdFZhbGlkYXRvci5qYXZh) | `75.00% <75.00%> (ø)` | | | [.../apache/hudi/client/utils/SparkValidatorUtils.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrVmFsaWRhdG9yVXRpbHMuamF2YQ==) | `93.18% <93.18%> (ø)` | | | ... and [26 more](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3153?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3153?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6eca06d...5806a2b](https://codecov.io/gh/apache/hudi/pull/3153?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] > Add Precommit validator framework > --------------------------------- > > Key: HUDI-2072 > URL: https://issues.apache.org/jira/browse/HUDI-2072 > Project: Apache Hudi > Issue Type: New Feature > Reporter: satish > Assignee: satish > Priority: Major > Labels: pull-request-available > > We want to run pre-commit validators before 'promoting' a inflight operation > to commit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
