[
https://issues.apache.org/jira/browse/HUDI-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374191#comment-17374191
]
ASF GitHub Bot commented on HUDI-2116:
--------------------------------------
xiarixiaoyao commented on a change in pull request #3209:
URL: https://github.com/apache/hudi/pull/3209#discussion_r663445355
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala
##########
@@ -462,6 +462,11 @@ object DataSourceWriteOptions {
.defaultValue(false)
.withDocumentation("Whether to sync the table as managed table.")
+ val HIVE_BATCH_SYNC_PARTITION_NUM: ConfigProperty[String] = ConfigProperty
Review comment:
oh, i see many boolean type config properties in DataSourceOptions.scala
are set to be ConfigProperty[String], so i follow this style, make this
config to String
in scala, it's better to set it Int instead of Integer. fix the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> sync 10w partitions to hive by using HiveSyncTool lead to the oom of hive
> MetaStore
> ------------------------------------------------------------------------------------
>
> Key: HUDI-2116
> URL: https://issues.apache.org/jira/browse/HUDI-2116
> Project: Apache Hudi
> Issue Type: Bug
> Components: Hive Integration
> Affects Versions: 0.8.0
> Environment: hive3.1.1
> hadoop 3.1.1
> Reporter: tao meng
> Assignee: tao meng
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.10.0
>
>
> when we try to sync 10w partitions to hive by using HiveSyncTool lead to the
> oom of hive MetaStore。
>
> here is a stress test for HiveSyncTool
> env：
> hive metastore -Xms16G -Xmx16G
> hive.metastore.client.socket.timeout=10800
>
> ||partitionNum||time consume||
> |100|37s|
> |1000|168s|
> |5000|1830s|
> |10000|timeout|
> |100000|hive metastore oom|
> HiveSyncTools sync all partitions to hive metastore at once。 when the
> partitions num is large ，it puts a lot of pressure on hive metastore。 for
> large partition num we should support batch sync 。
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
