garyli1019 commented on a change in pull request #3181:
URL: https://github.com/apache/hudi/pull/3181#discussion_r664211628
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieFileSliceReader.java
##########
@@ -41,11 +43,26 @@
while (baseIterator.hasNext()) {
GenericRecord record = (GenericRecord) baseIterator.next();
HoodieRecord<T> hoodieRecord =
SpillableMapUtils.convertToHoodieRecordPayload(record, payloadClass);
- scanner.processNextRecord(hoodieRecord);
+ processNextRecord(scanner, hoodieRecord);
}
return new HoodieFileSliceReader(scanner.iterator());
}
+ private static void processNextRecord(HoodieMergedLogRecordScanner scanner,
HoodieRecord<? extends HoodieRecordPayload> hoodieRecord) {
Review comment:
We should always to call `preCombine` or `combineAndGetUpdateValue` to
determine which record to keep. I see `processNextRecord` is calling preCombine
but still using the Deprecated API. If we update it to `preCombine(T another,
Properties properties)`, the order should be expected then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
