[
https://issues.apache.org/jira/browse/HUDI-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375514#comment-17375514
]
ASF GitHub Bot commented on HUDI-2132:
--------------------------------------
danny0405 commented on a change in pull request #3223:
URL: https://github.com/apache/hudi/pull/3223#discussion_r663880814
##########
File path:
hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteFunction.java
##########
@@ -659,8 +659,8 @@ private void flushRemaining(boolean isEndInput) {
.taskID(taskID)
.instantTime(currentInstant)
.writeStatus(writeStatus)
- .isLastBatch(true)
- .isEndInput(isEndInput)
+ .lastBatch(true)
+ .endInput(isEndInput)
Review comment:
No need to change that because `StreamWriteFunction` is not a POJO.
##########
File path:
hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteFunction.java
##########
@@ -659,8 +659,8 @@ private void flushRemaining(boolean isEndInput) {
.taskID(taskID)
.instantTime(currentInstant)
.writeStatus(writeStatus)
- .isLastBatch(true)
- .isEndInput(isEndInput)
+ .lastBatch(true)
+ .endInput(isEndInput)
Review comment:
Because `WriteMetadataEvent` is a POJO, we should respect the name
pattern of the POJO, while there is no need to change for `StreamWriteFunction`.
##########
File path:
hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteFunction.java
##########
@@ -659,8 +659,8 @@ private void flushRemaining(boolean isEndInput) {
.taskID(taskID)
.instantTime(currentInstant)
.writeStatus(writeStatus)
- .isLastBatch(true)
- .isEndInput(isEndInput)
+ .lastBatch(true)
+ .endInput(isEndInput)
Review comment:
Fine, have changed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Make coordinator events as POJO for efficient serialization
> -----------------------------------------------------------
>
> Key: HUDI-2132
> URL: https://issues.apache.org/jira/browse/HUDI-2132
> Project: Apache Hudi
> Issue Type: Improvement
> Components: Flink Integration
> Reporter: Danny Chen
> Assignee: Danny Chen
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
