vinothchandar commented on a change in pull request #3129:
URL: https://github.com/apache/hudi/pull/3129#discussion_r664772534
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -289,6 +289,8 @@ public void refreshTimeline() throws IOException {
srcRecordsWithCkpt.getRight().getLeft(), metrics,
overallTimerContext);
}
+ metrics.updateDeltaStreamerSyncMetrics(System.currentTimeMillis());
Review comment:
Yes. This patch is okay as long as you can set your alerts to catch - no
sync metrics being emitted for a period of time.
Another way to monitor would be to emit a 1 for success and 0 for failure.
And it lets you set alerts on a rolling window aggregate.
I have done both personally. Cant say one is better over other by a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
