[
https://issues.apache.org/jira/browse/HUDI-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377670#comment-17377670
]
ASF GitHub Bot commented on HUDI-2143:
--------------------------------------
yanghua commented on a change in pull request #3238:
URL: https://github.com/apache/hudi/pull/3238#discussion_r666610891
##########
File path:
hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java
##########
@@ -199,6 +199,12 @@ private static void setupCleaningOptions(Configuration
conf) {
conf.setInteger(FlinkOptions.ARCHIVE_MIN_COMMITS, commitsToRetain + 10);
conf.setInteger(FlinkOptions.ARCHIVE_MAX_COMMITS, commitsToRetain + 20);
}
+ if (conf.getBoolean(FlinkOptions.COMPACTION_SCHEDULE_ENABLED)
Review comment:
IMO, @garyli1019 's opinion is reasonable. @danny0405 I know what's your
purpose. Can we define an explicit config option for this? So that users can
know this detail information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Tweak the default compaction target IO to 500GB when flink async compaction
> is off
> ----------------------------------------------------------------------------------
>
> Key: HUDI-2143
> URL: https://issues.apache.org/jira/browse/HUDI-2143
> Project: Apache Hudi
> Issue Type: Improvement
> Components: Flink Integration
> Reporter: Danny Chen
> Assignee: Danny Chen
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
