codope commented on a change in pull request #3184:
URL: https://github.com/apache/hudi/pull/3184#discussion_r666687674



##########
File path: 
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -449,6 +449,9 @@ public void refreshTimeline() throws IOException {
       case BULK_INSERT:
         writeStatusRDD = writeClient.bulkInsert(records, instantTime);
         break;
+      case INSERT_OVERWRITE:

Review comment:
       Thanks! Could you also add unit tests for the two operation types in 
`TestHoodieDeltaStreamer`? Specifically, we can start with insert/bulk insert 
and then verify for insert_overwrite, with and without partition, that the 
writes are successful. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to