lw309637554 commented on a change in pull request #3240:
URL: https://github.com/apache/hudi/pull/3240#discussion_r668354266



##########
File path: 
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/UpsertPartitioner.java
##########
@@ -146,7 +146,7 @@ private int addUpdateBucket(String partitionPath, String 
fileIdHint) {
    * @return smallFiles not in clustering
    */
   private List<SmallFile> filterSmallFilesInClustering(final Set<String> 
pendingClusteringFileGroupsId, final List<SmallFile> smallFiles) {
-    if (this.config.isClusteringEnabled()) {

Review comment:
       @satishkotha @zhangyue19921010
   At first we have two config for clustering. If set 
ASYNC_CLUSTERING_ENABLE_OPT_KEY will be ok.
     public boolean isAsyncClusteringEnabled() {
       return 
Boolean.parseBoolean(props.getProperty(HoodieClusteringConfig.ASYNC_CLUSTERING_ENABLE_OPT_KEY));
     }
   
     public boolean isClusteringEnabled() {
       // TODO: future support async clustering
       return inlineClusteringEnabled() || isAsyncClusteringEnabled();
     }
    




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to