[
https://issues.apache.org/jira/browse/HUDI-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379496#comment-17379496
]
Vinoth Chandar commented on HUDI-2151:
--------------------------------------
These need a default value.
{code:java}
public static final ConfigProperty<String> ZK_PORT_PROP = ConfigProperty
.key(ZK_PORT_PROP_KEY)
.noDefaultValue()
.sinceVersion("0.8.0")
.withDocumentation("Zookeeper port to connect to.");
public static final ConfigProperty<String> ZK_LOCK_KEY_PROP = ConfigProperty
.key(ZK_LOCK_KEY_PROP_KEY)
.noDefaultValue()
.sinceVersion("0.8.0")
.withDocumentation("Key name under base_path at which to create a ZNode and
acquire lock. "
+ "Final path on zk will look like base_path/lock_key. We recommend setting
this to the table name");{code}
> Make performant out-of-box configs
> ----------------------------------
>
> Key: HUDI-2151
> URL: https://issues.apache.org/jira/browse/HUDI-2151
> Project: Apache Hudi
> Issue Type: Sub-task
> Components: Code Cleanup, Docs
> Reporter: Vinoth Chandar
> Assignee: Vinoth Chandar
> Priority: Major
>
> We have quite a few configs which deliver better performance or usability,
> but guarded by flags.
> This is to identify them, change them, test (functionally, perf) and make
> them default
>
> Need to ensure we also capture all the backwards compatibility issues that
> can arise
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
