Samrat002 commented on a change in pull request #3184:
URL: https://github.com/apache/hudi/pull/3184#discussion_r669257559
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkInsertOverwriteCommitActionExecutor.java
##########
@@ -66,11 +65,6 @@ protected Partitioner getPartitioner(WorkloadProfile
profile) {
return new SparkInsertOverwritePartitioner(profile, context, table,
config);
}
- @Override
- protected String getCommitActionType() {
Review comment:
@satishkotha greetings !
with reference to the function!
https://github.com/apache/hudi/blob/03668dbaf1a60428d7e0d68c6622605e0809150a/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkInsertOverwriteCommitActionExecutor.java#L70
Why specifically we need `HoodieTimeline.REPLACE_COMMIT_ACTION` for
`SparkInsertOverwriteCommitActionExecutor` ?
What is the intention behind it If you can enlighten it would be really
helpful!
cc: @codope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
