leesf commented on a change in pull request #3230:
URL: https://github.com/apache/hudi/pull/3230#discussion_r669749377
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java
##########
@@ -189,8 +191,14 @@ protected boolean isUpdateRecord(HoodieRecord<T>
hoodieRecord) {
private Option<IndexedRecord> getIndexedRecord(HoodieRecord<T> hoodieRecord)
{
Option<Map<String, String>> recordMetadata =
hoodieRecord.getData().getMetadata();
try {
- Option<IndexedRecord> avroRecord =
hoodieRecord.getData().getInsertValue(tableSchema,
- config.getProps());
+ // Pass the isUpdateRecord to the props for HoodieRecordPayload to judge
+ // Whether it is a update or insert record.
+ boolean isUpdateRecord = isUpdateRecord(hoodieRecord);
Review comment:
HoodieAppendHandle should handle update records, here you mean use
global index?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
