rmahindra123 commented on a change in pull request #3128:
URL: https://github.com/apache/hudi/pull/3128#discussion_r670094851



##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java
##########
@@ -200,7 +200,7 @@ protected void initializeIncomingRecordsMap() {
       LOG.info("MaxMemoryPerPartitionMerge => " + memoryForMerge);
       this.keyToNewRecords = new ExternalSpillableMap<>(memoryForMerge, 
config.getSpillableMapBasePath(),
           new DefaultSizeEstimator(), new 
HoodieRecordSizeEstimator(tableSchema),
-          config.getSpillableDiskMapType());
+          config.getSpillableDiskMapType(), 
config.isBitCaskDiskMapCompressionEnabled());

Review comment:
       Good point, will be done in a follow up PR 
https://issues.apache.org/jira/browse/HUDI-2044




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to