[
https://issues.apache.org/jira/browse/HUDI-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17381905#comment-17381905
]
ASF GitHub Bot commented on HUDI-2169:
--------------------------------------
garyli1019 commented on a change in pull request #3265:
URL: https://github.com/apache/hudi/pull/3265#discussion_r671079725
##########
File path:
hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteFunction.java
##########
@@ -100,8 +100,8 @@
* @param <I> Type of the input record
* @see StreamWriteOperatorCoordinator
*/
-public class StreamWriteFunction<K, I, O>
- extends KeyedProcessFunction<K, I, O>
+public class StreamWriteFunction<I, O>
+ extends ProcessFunction<I, O>
Review comment:
Looks like even we need the keyBy, we can still use the
`ProcessFunction` here instead of `KeyedProcessFunction` right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove keyby when write.operation is Insert
> -------------------------------------------
>
> Key: HUDI-2169
> URL: https://issues.apache.org/jira/browse/HUDI-2169
> Project: Apache Hudi
> Issue Type: Improvement
> Components: Flink Integration
> Reporter: yuzhaojing
> Assignee: yuzhaojing
> Priority: Minor
> Labels: pull-request-available
>
> When write.operation is Insert, user can tolerate data duplication or data
> that does not need to be merged. In this case, the keyby is unnecessary.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
