[
https://issues.apache.org/jira/browse/HUDI-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382192#comment-17382192
]
ASF GitHub Bot commented on HUDI-2161:
--------------------------------------
nsivabalan commented on a change in pull request #3247:
URL: https://github.com/apache/hudi/pull/3247#discussion_r671383496
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/SimpleKeyGenerator.java
##########
@@ -72,4 +75,16 @@ public String getPartitionPath(Row row) {
return RowKeyGeneratorHelper.getPartitionPathFromRow(row,
getPartitionPathFields(),
hiveStylePartitioning, partitionPathPositions);
}
+
+ @Override
+ public String getPartitionPath(InternalRow row, StructType structType) {
+ buildFieldDataTypesMapIfNeeded(structType);
Review comment:
During instantiation of KeyGen, we never know if we are ever going to
invoke these methods. As you might be aware, these are invoked only in row
writer path and only if meta cols are disabled. So, as of now, our constructors
for keyGen are are designed in such a way. So, may be we can add public methods
to set the structType and expect callers to set it appropriately before calling
these methods.
I took precendence from what we did when we added support for
getPartitionPath(Row).
Let me know how you wanna go about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Add support to disable meta column to BulkInsert Row Writer path
> ----------------------------------------------------------------
>
> Key: HUDI-2161
> URL: https://issues.apache.org/jira/browse/HUDI-2161
> Project: Apache Hudi
> Issue Type: Improvement
> Reporter: sivabalan narayanan
> Priority: Major
> Labels: pull-request-available
>
> Objective here is to disable all meta columns so as to avoid storage cost.
> Also, some benefits could be seen in write latency with row writer path as no
> special handling is required at RowCreateHandle layer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
