nsivabalan commented on a change in pull request #3282:
URL: https://github.com/apache/hudi/pull/3282#discussion_r671628290
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieFileWriterFactory.java
##########
@@ -58,16 +59,15 @@
private static <T extends HoodieRecordPayload, R extends IndexedRecord>
HoodieFileWriter<R> newParquetFileWriter(
String instantTime, Path path, HoodieWriteConfig config, Schema schema,
HoodieTable hoodieTable,
- TaskContextSupplier taskContextSupplier) throws IOException {
- BloomFilter filter = createBloomFilter(config);
- HoodieAvroWriteSupport writeSupport =
- new HoodieAvroWriteSupport(new
AvroSchemaConverter(hoodieTable.getHadoopConf()).convert(schema), schema,
filter);
+ TaskContextSupplier taskContextSupplier, boolean populateMetaFields,
boolean enableBloomFilter) throws IOException {
+ BloomFilter filter = enableBloomFilter ? createBloomFilter(config) : null;
Review comment:
Already HoodieAvroWriteSupport handles null bloom Filter and hence using
null here. If you prefer, I can change that to Option<BloomFilter>.
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -1588,6 +1588,11 @@ public Builder withWriteMetaKeyPrefixes(String
writeMetaKeyPrefixes) {
return this;
}
+ public Builder withPopulateMetaFields(boolean populateMetaFields) {
Review comment:
Can you please clarify me something. if we wish to store the property in
hoodie.properties and is part of HoodieTableConfig, then we should set the
config via HoodieWriteConfigBuilder.withHoodieTableConfig(new
HoodieTableConfigBuilder().withPopulate ... sort of? and exposing setter here
in HoodieWriteConfig is not the right way to go about?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
