[ 
https://issues.apache.org/jira/browse/HUDI-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383237#comment-17383237
 ] 

ASF GitHub Bot commented on HUDI-1771:
--------------------------------------

danny0405 commented on a change in pull request #3285:
URL: https://github.com/apache/hudi/pull/3285#discussion_r672172626



##########
File path: 
hudi-flink/src/main/java/org/apache/hudi/table/format/mor/MergeOnReadInputFormat.java
##########
@@ -624,6 +634,14 @@ public boolean reachedEnd() throws IOException {
       return true;
     }
 
+    private Option<IndexedRecord> getInsetValue(String curKey) throws 
IOException {
+      final HoodieRecord<?> record = logRecords.get(curKey);
+      if (HoodieOperation.isDelete(record.getOperation())) {
+        return Option.empty();

Review comment:
       Put `!emitDelete` in the front.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Propagate CDC format for hoodie
> -------------------------------
>
>                 Key: HUDI-1771
>                 URL: https://issues.apache.org/jira/browse/HUDI-1771
>             Project: Apache Hudi
>          Issue Type: New Feature
>          Components: Flink Integration
>            Reporter: Danny Chen
>            Assignee: Zheng yunhong
>            Priority: Major
>              Labels: pull-request-available, sev:normal
>             Fix For: 0.9.0
>
>
> Like what we discussed in the dev mailing list: 
> https://lists.apache.org/thread.html/r31b2d1404e4e043a5f875b78105ba6f9a801e78f265ad91242ad5eb2%40%3Cdev.hudi.apache.org%3E
> Keep the change flags make new use cases possible: using HUDI as the unified 
> storage format for DWD and DWS layer.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to