[
https://issues.apache.org/jira/browse/HUDI-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383892#comment-17383892
]
ASF GitHub Bot commented on HUDI-1518:
--------------------------------------
zhangyue19921010 opened a new pull request #3310:
URL: https://github.com/apache/hudi/pull/3310
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a
pull request.*
https://issues.apache.org/jira/browse/HUDI-1518
## What is the purpose of the pull request
Since https://github.com/apache/hudi/pull/2422 Cleaner now takes care of
removing replaced file groups. This call to deleteReplacedFileGroups can be
removed.
Also it's a little confused that archive can delete data file even users set
auto.clean false.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test
coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please
describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove replaced files logic from archival
> -----------------------------------------
>
> Key: HUDI-1518
> URL: https://issues.apache.org/jira/browse/HUDI-1518
> Project: Apache Hudi
> Issue Type: Task
> Affects Versions: 0.9.0
> Reporter: satish
> Priority: Minor
> Fix For: 0.9.0
>
>
> See
> https://github.com/apache/hudi/blob/79ec7b4894b997183a6e10fdc19d34f5ab4ea437/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTimelineArchiveLog.java#L324
> Archival tries to delete replaced files in 'deleteReplacedFileGroups' method.
> We changed cleaner to delete replaced files. So this is no longer needed. We
> can instead validate that replaced files no longer exist on disk during
> archival.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
