[
https://issues.apache.org/jira/browse/HUDI-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384329#comment-17384329
]
ASF GitHub Bot commented on HUDI-648:
-------------------------------------
codecov-commenter edited a comment on pull request #3312:
URL: https://github.com/apache/hudi/pull/3312#issuecomment-883444320
#
[Codecov](https://codecov.io/gh/apache/hudi/pull/3312?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3312](https://codecov.io/gh/apache/hudi/pull/3312?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(82153aa) into
[master](https://codecov.io/gh/apache/hudi/commit/a086d255c89d12eb42cad8c5ae0e000f3b83bbe6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(a086d25) will **decrease** coverage by `0.22%`.
> The diff coverage is `12.15%`.
[](https://codecov.io/gh/apache/hudi/pull/3312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3312 +/- ##
============================================
- Coverage 47.74% 47.52% -0.23%
- Complexity 5591 5598 +7
============================================
Files 938 944 +6
Lines 41823 42078 +255
Branches 4213 4238 +25
============================================
+ Hits 19968 19997 +29
- Misses 20070 20286 +216
- Partials 1785 1795 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| hudicli | `39.97% <ø> (ø)` | |
| hudiclient | `34.28% <14.73%> (-0.28%)` | :arrow_down: |
| hudicommon | `48.38% <1.61%> (-0.26%)` | :arrow_down: |
| hudiflink | `59.48% <ø> (+0.04%)` | :arrow_up: |
| hudihadoopmr | `51.99% <66.66%> (-0.03%)` | :arrow_down: |
| hudisparkdatasource | `67.04% <ø> (-0.06%)` | :arrow_down: |
| hudisync | `55.97% <ø> (ø)` | |
| huditimelineservice | `64.07% <ø> (ø)` | |
| hudiutilities | `59.84% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
| [Impacted
Files](https://codecov.io/gh/apache/hudi/pull/3312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[.../apache/hudi/client/AbstractHoodieWriteClient.java](https://codecov.io/gh/apache/hudi/pull/3312/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9BYnN0cmFjdEhvb2RpZVdyaXRlQ2xpZW50LmphdmE=)
| `0.00% <ø> (ø)` | |
|
[...pache/hudi/error/HoodieBackedErrorTableWriter.java](https://codecov.io/gh/apache/hudi/pull/3312/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2Vycm9yL0hvb2RpZUJhY2tlZEVycm9yVGFibGVXcml0ZXIuamF2YQ==)
| `0.00% <0.00%> (ø)` | |
|
[...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://codecov.io/gh/apache/hudi/pull/3312/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==)
| `0.00% <0.00%> (ø)` | |
|
[.../hudi/error/FlinkHoodieBackedErrorTableWriter.java](https://codecov.io/gh/apache/hudi/pull/3312/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXJyb3IvRmxpbmtIb29kaWVCYWNrZWRFcnJvclRhYmxlV3JpdGVyLmphdmE=)
| `0.00% <0.00%> (ø)` | |
|
[.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://codecov.io/gh/apache/hudi/pull/3312/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=)
| `33.33% <0.00%> (-7.52%)` | :arrow_down: |
|
[...e/hudi/error/JavaHoodieBackedErrorTableWriter.java](https://codecov.io/gh/apache/hudi/pull/3312/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9lcnJvci9KYXZhSG9vZGllQmFja2VkRXJyb3JUYWJsZVdyaXRlci5qYXZh)
| `0.00% <0.00%> (ø)` | |
|
[...che/hudi/common/config/HoodieErrorTableConfig.java](https://codecov.io/gh/apache/hudi/pull/3312/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZpZy9Ib29kaWVFcnJvclRhYmxlQ29uZmlnLmphdmE=)
| `0.00% <0.00%> (ø)` | |
|
[...on/model/OverwriteWithLatestAvroSchemaPayload.java](https://codecov.io/gh/apache/hudi/pull/3312/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL092ZXJ3cml0ZVdpdGhMYXRlc3RBdnJvU2NoZW1hUGF5bG9hZC5qYXZh)
| `0.00% <0.00%> (ø)` | |
|
[...va/org/apache/hudi/common/util/TablePathUtils.java](https://codecov.io/gh/apache/hudi/pull/3312/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvVGFibGVQYXRoVXRpbHMuamF2YQ==)
| `59.52% <0.00%> (-8.05%)` | :arrow_down: |
|
[...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3312/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh)
| `42.78% <15.38%> (-0.59%)` | :arrow_down: |
| ... and [14
more](https://codecov.io/gh/apache/hudi/pull/3312/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/hudi/pull/3312?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/hudi/pull/3312?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[a086d25...82153aa](https://codecov.io/gh/apache/hudi/pull/3312?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Implement error log/table for Datasource/DeltaStreamer/WriteClient/Compaction
> writes
> ------------------------------------------------------------------------------------
>
> Key: HUDI-648
> URL: https://issues.apache.org/jira/browse/HUDI-648
> Project: Apache Hudi
> Issue Type: New Feature
> Components: DeltaStreamer, Spark Integration, Writer Core
> Reporter: Vinoth Chandar
> Assignee: liujinhui
> Priority: Major
> Labels: pull-request-available, sev:normal, user-support-issues
> Attachments: image-2021-03-03-11-40-21-083.png
>
>
> We would like a way to hand the erroring records from writing or compaction
> back to the users, in a separate table or log. This needs to work generically
> across all the different writer paths.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
