[
https://issues.apache.org/jira/browse/HUDI-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384554#comment-17384554
] ASF GitHub Bot commented on HUDI-2072: -------------------------------------- codecov-commenter edited a comment on pull request #3153: URL: https://github.com/apache/hudi/pull/3153#issuecomment-868791906 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3153?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3153](https://codecov.io/gh/apache/hudi/pull/3153?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (966ea04) into [master](https://codecov.io/gh/apache/hudi/commit/6eca06d074520140d7bc67b48bd2b9a5b76f0a87?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6eca06d) will **decrease** coverage by `19.48%`. > The diff coverage is `56.34%`. [](https://codecov.io/gh/apache/hudi/pull/3153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #3153 +/- ## ============================================= - Coverage 47.51% 28.02% -19.49% + Complexity 5429 1363 -4066 ============================================= Files 922 397 -525 Lines 40968 15789 -25179 Branches 4105 1395 -2710 ============================================= - Hits 19464 4425 -15039 + Misses 19780 11032 -8748 + Partials 1724 332 -1392 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `21.80% <56.34%> (-12.78%)` | :arrow_down: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudisparkdatasource | `?` | | | hudisync | `4.88% <ø> (-49.18%)` | :arrow_down: | | huditimelineservice | `?` | | | hudiutilities | `59.87% <ø> (+1.85%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...he/hudi/config/HoodiePreCommitValidatorConfig.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVDb21taXRWYWxpZGF0b3JDb25maWcuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `0.00% <0.00%> (-42.79%)` | :arrow_down: | | [.../table/action/commit/BaseCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...alidator/SqlQueryInequalityPreCommitValidator.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3ZhbGlkYXRvci9TcWxRdWVyeUluZXF1YWxpdHlQcmVDb21taXRWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [.../bootstrap/SparkBootstrapCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2Jvb3RzdHJhcC9TcGFya0Jvb3RzdHJhcENvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | | | [.../validator/SqlQueryEqualityPreCommitValidator.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3ZhbGlkYXRvci9TcWxRdWVyeUVxdWFsaXR5UHJlQ29tbWl0VmFsaWRhdG9yLmphdmE=) | `63.63% <63.63%> (ø)` | | | [...idator/SqlQuerySingleResultPreCommitValidator.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3ZhbGlkYXRvci9TcWxRdWVyeVNpbmdsZVJlc3VsdFByZUNvbW1pdFZhbGlkYXRvci5qYXZh) | `75.00% <75.00%> (ø)` | | | [...hudi/client/validator/SparkPreCommitValidator.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3ZhbGlkYXRvci9TcGFya1ByZUNvbW1pdFZhbGlkYXRvci5qYXZh) | `82.35% <82.35%> (ø)` | | | [.../apache/hudi/client/utils/SparkValidatorUtils.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrVmFsaWRhdG9yVXRpbHMuamF2YQ==) | `93.47% <93.47%> (ø)` | | | [...i/client/validator/SqlQueryPreCommitValidator.java](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3ZhbGlkYXRvci9TcWxRdWVyeVByZUNvbW1pdFZhbGlkYXRvci5qYXZh) | `95.83% <95.83%> (ø)` | | | ... and [695 more](https://codecov.io/gh/apache/hudi/pull/3153/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3153?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3153?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6eca06d...966ea04](https://codecov.io/gh/apache/hudi/pull/3153?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] > Add Precommit validator framework > --------------------------------- > > Key: HUDI-2072 > URL: https://issues.apache.org/jira/browse/HUDI-2072 > Project: Apache Hudi > Issue Type: New Feature > Reporter: satish > Assignee: satish > Priority: Major > Labels: pull-request-available > > We want to run pre-commit validators before 'promoting' a inflight operation > to commit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
