[
https://issues.apache.org/jira/browse/HUDI-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385070#comment-17385070
] ASF GitHub Bot commented on HUDI-1848: -------------------------------------- codecov-commenter edited a comment on pull request #2879: URL: https://github.com/apache/hudi/pull/2879#issuecomment-826666454 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2879?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2879](https://codecov.io/gh/apache/hudi/pull/2879?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f360b8b) into [master](https://codecov.io/gh/apache/hudi/commit/2099bf41db76e9a6e946aa41c318b7c0e18be04d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2099bf4) will **decrease** coverage by `2.03%`. > The diff coverage is `79.48%`. [](https://codecov.io/gh/apache/hudi/pull/2879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #2879 +/- ## ============================================ - Coverage 47.84% 45.80% -2.04% - Complexity 5564 5647 +83 ============================================ Files 936 1003 +67 Lines 41652 43968 +2316 Branches 4195 4415 +220 ============================================ + Hits 19928 20140 +212 - Misses 19952 22037 +2085 - Partials 1772 1791 +19 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `39.97% <ø> (ø)` | | | hudiclient | `34.55% <ø> (+0.03%)` | :arrow_up: | | hudicommon | `48.63% <ø> (-0.06%)` | :arrow_down: | | hudiflink | `59.65% <ø> (+0.21%)` | :arrow_up: | | hudihadoopmr | `52.02% <ø> (ø)` | | | hudiintegtest | `0.00% <ø> (?)` | | | hudisparkdatasource | `67.04% <ø> (-0.24%)` | :arrow_down: | | hudisync | `59.28% <79.48%> (+3.30%)` | :arrow_up: | | huditimelineservice | `64.07% <ø> (ø)` | | | hudiutilities | `59.87% <ø> (+0.10%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/2879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...org/apache/hudi/hive/ddl/HiveQueryDDLExecutor.java](https://codecov.io/gh/apache/hudi/pull/2879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvZGRsL0hpdmVRdWVyeURETEV4ZWN1dG9yLmphdmE=) | `71.15% <71.15%> (ø)` | | | [...in/java/org/apache/hudi/hive/ddl/JDBCExecutor.java](https://codecov.io/gh/apache/hudi/pull/2879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvZGRsL0pEQkNFeGVjdXRvci5qYXZh) | `73.13% <73.13%> (ø)` | | | [...in/java/org/apache/hudi/hive/HoodieHiveClient.java](https://codecov.io/gh/apache/hudi/pull/2879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvSG9vZGllSGl2ZUNsaWVudC5qYXZh) | `66.40% <73.91%> (-3.74%)` | :arrow_down: | | [.../java/org/apache/hudi/hive/ddl/HMSDDLExecutor.java](https://codecov.io/gh/apache/hudi/pull/2879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvZGRsL0hNU0RETEV4ZWN1dG9yLmphdmE=) | `81.45% <81.45%> (ø)` | | | [...rg/apache/hudi/hive/ddl/QueryBasedDDLExecutor.java](https://codecov.io/gh/apache/hudi/pull/2879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvZGRsL1F1ZXJ5QmFzZWRERExFeGVjdXRvci5qYXZh) | `84.94% <84.94%> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://codecov.io/gh/apache/hudi/pull/2879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `70.90% <86.20%> (+1.53%)` | :arrow_up: | | [...main/java/org/apache/hudi/hive/HiveSyncConfig.java](https://codecov.io/gh/apache/hudi/pull/2879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvSGl2ZVN5bmNDb25maWcuamF2YQ==) | `98.24% <100.00%> (ø)` | | | [...c/main/java/org/apache/hudi/hive/HiveSyncTool.java](https://codecov.io/gh/apache/hudi/pull/2879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvSGl2ZVN5bmNUb29sLmphdmE=) | `78.12% <100.00%> (ø)` | | | [...va/org/apache/hudi/keygen/BuiltinKeyGenerator.java](https://codecov.io/gh/apache/hudi/pull/2879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL0J1aWx0aW5LZXlHZW5lcmF0b3IuamF2YQ==) | `62.12% <0.00%> (-10.86%)` | :arrow_down: | | [...g/apache/hudi/keygen/GlobalDeleteKeyGenerator.java](https://codecov.io/gh/apache/hudi/pull/2879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL0dsb2JhbERlbGV0ZUtleUdlbmVyYXRvci5qYXZh) | `90.90% <0.00%> (-9.10%)` | :arrow_down: | | ... and [115 more](https://codecov.io/gh/apache/hudi/pull/2879/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/2879?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/2879?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2099bf4...f360b8b](https://codecov.io/gh/apache/hudi/pull/2879?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] > Add support for HMS in Hive-sync-tool > ------------------------------------- > > Key: HUDI-1848 > URL: https://issues.apache.org/jira/browse/HUDI-1848 > Project: Apache Hudi > Issue Type: New Feature > Reporter: Jagmeet Bali > Priority: Minor > Labels: pull-request-available, sev:normal > > Add support for HMS in Hive-sync-tool > Currently there are two ways to sun DDL queries in hive-sync-tool. > This work adds on top of > [https://github.com/apache/hudi/pull/2532|https://github.com/apache/hudi/pull/2532/files] > and adds a pluggable way to support > new way to run DDL queries using HMS. > > Different DDL executors can be selected via diff syncConfig options > useJDBC true -> JDBCExecutor will be used > useJDBC false -> QlHiveQueryExecutor will be used > useHMS true -> HMSDDLExecutor will be used. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
