nsivabalan commented on a change in pull request #3306:
URL: https://github.com/apache/hudi/pull/3306#discussion_r674403754
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java
##########
@@ -101,33 +103,44 @@
protected long updatedRecordsWritten = 0;
protected long insertRecordsWritten = 0;
protected boolean useWriterSchema;
+ protected boolean populateMetaFields;
+ protected Option<BaseKeyGenerator> keyGeneratorOpt;
Review comment:
I initially thought of moving this to HoodieWriteHandle thinking all
handles might need this. but looks like neither create nor append handle needs
key gen since on the write path, we have HoodieKey handy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
