[
https://issues.apache.org/jira/browse/HUDI-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389134#comment-17389134
]
ASF GitHub Bot commented on HUDI-1425:
--------------------------------------
vinothchandar commented on a change in pull request #2296:
URL: https://github.com/apache/hudi/pull/2296#discussion_r678732748
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -366,6 +366,11 @@
.withDocumentation("When enabled, records in older schema are rewritten
into newer schema during upsert,delete and background"
+ " compaction,clustering operations.");
+ public static final ConfigProperty<Boolean> ALLOW_EMPTY_COMMIT =
ConfigProperty
+ .key("hoodie.allow.empty.commmit")
+ .defaultValue(true)
+ .withDocumentation("Whether to allow generate empty commit when the
input is empty.");
Review comment:
reword: `Whether to allow generation of empty commits, even if no data
was written in the commit. It's useful in cases where extra metadata needs to
be published regardless e.g tracking source offsets when ingesting data`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Performance loss with the additional hoodieRecords.isEmpty() in
> HoodieSparkSqlWriter#write
> ------------------------------------------------------------------------------------------
>
> Key: HUDI-1425
> URL: https://issues.apache.org/jira/browse/HUDI-1425
> Project: Apache Hudi
> Issue Type: Improvement
> Components: Spark Integration
> Affects Versions: 0.9.0
> Reporter: pengzhiwei
> Assignee: pengzhiwei
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 0.9.0
>
> Attachments: 截屏2020-11-30 下午9.47.55.png
>
>
> Currently in HoodieSparkSqlWriter#write, there is a _isEmpty()_ test for
> _hoodieRecords._ This may be a heavy operator in the case when the
> _hoodieRecords_ contains complex RDD operate.
> !截屏2020-11-30 下午9.47.55.png|width=1255,height=161!
> IMO this test does nothing to do with the performance improve，but rather
> affects performance.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
