[
https://issues.apache.org/jira/browse/HUDI-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389161#comment-17389161
]
ASF GitHub Bot commented on HUDI-2090:
--------------------------------------
vinothchandar commented on a change in pull request #3329:
URL: https://github.com/apache/hudi/pull/3329#discussion_r678764756
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java
##########
@@ -61,13 +61,15 @@
*
* Inspired by https://github.com/basho/bitcask
*/
-public final class BitCaskDiskMap<T extends Serializable, R extends
Serializable> implements DiskMap<T, R> {
+public final class BitCaskDiskMap<T extends Serializable, R extends
Serializable> extends DiskMap<T, R> {
public static final int BUFFER_SIZE = 128 * 1024; // 128 KB
private static final Logger LOG = LogManager.getLogger(BitCaskDiskMap.class);
// Caching byte compression/decompression to avoid creating instances for
every operation
private static final ThreadLocal<CompressionHandler> DISK_COMPRESSION_REF =
ThreadLocal.withInitial(CompressionHandler::new);
+ private static final String BITCASK_DISK_MAP = "bitcask";
Review comment:
Instead of adding a new string, can't we just reuse the enum w'e have
for map type? Like have a getType() abstract method and use it to generate the
string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> when hudi metadata is enabled, use different user to query table, the query
> will failed
> -----------------------------------------------------------------------------------------
>
> Key: HUDI-2090
> URL: https://issues.apache.org/jira/browse/HUDI-2090
> Project: Apache Hudi
> Issue Type: Bug
> Components: Common Core
> Affects Versions: 0.8.0
> Reporter: tao meng
> Assignee: tao meng
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> when hudi metadata is enabled, use different user to query table, the query
> will failed.
>
> The user permissions of the temporary directory generated by DiskBasedMap are
> incorrect. This directory only has permissions for the user of current
> operation, and other users have no permissions to access it, which leads to
> this problem
> test step：
> step1: create hudi table with metadata enabled.
> step1： create two user（omm，user2）
> step2:
> f1) use omm to query hudi table
> DiskBasedMap will generate view_map with permissions drwx------.
> 2) then user user2 to query hudi table
> now user2 has no right to access view_map which created by omm, the
> exception will throws:
> org.apache.hudi.exception.HoodieIOException: IOException when creating
> ExternalSplillableMap at /tmp/view_map
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
