zhangyue19921010 commented on a change in pull request #3259:
URL: https://github.com/apache/hudi/pull/3259#discussion_r679615918
##########
File path:
hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieDeltaStreamer.java
##########
@@ -1115,6 +1125,47 @@ public void testAsyncClusteringServiceWithCompaction()
throws Exception {
});
}
+ @Test
Review comment:
nice idea, changed
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieClusteringJob.java
##########
@@ -118,20 +134,41 @@ public static void main(String[] args) {
jsc.stop();
}
+ private static void validateRunningMode(Config cfg) {
+ // --mode has a higher priority than --schedule
+ // If we remove --schedule option in the future we need to change
runningMode default value to EXECUTE
+ if (StringUtils.isNullOrEmpty(cfg.runningMode)) {
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
