[
https://issues.apache.org/jira/browse/HUDI-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390712#comment-17390712
]
ASF GitHub Bot commented on HUDI-2255:
--------------------------------------
vinothchandar commented on a change in pull request #3373:
URL: https://github.com/apache/hudi/pull/3373#discussion_r680116010
##########
File path: docker/demo/sparksql-incremental.commands
##########
@@ -27,8 +27,8 @@ import org.apache.hadoop.fs.FileSystem;
val fs = FileSystem.get(spark.sparkContext.hadoopConfiguration)
val beginInstantTime = HoodieDataSourceHelpers.listCommitsSince(fs,
"/user/hive/warehouse/stock_ticks_cow", "00000").get(0)
val hoodieIncQueryDF = spark.read.format("org.apache.hudi").
- option(DataSourceReadOptions.QUERY_TYPE_OPT_KEY.key(),
DataSourceReadOptions.QUERY_TYPE_INCREMENTAL_OPT_VAL).
-
option(DataSourceReadOptions.BEGIN_INSTANTTIME_OPT_KEY.key(), beginInstantTime).
+ option(DataSourceReadOptions.QUERY_TYPE_OPT.key(),
DataSourceReadOptions.QUERY_TYPE_INCREMENTAL_OPT_VAL).
Review comment:
I am okay keeping `_PROP` or removing. It's not as bad as `_OPT_KEY`.
It also has higher blast radius. may be leave it alone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor DataSourceOptions
> --------------------------
>
> Key: HUDI-2255
> URL: https://issues.apache.org/jira/browse/HUDI-2255
> Project: Apache Hudi
> Issue Type: Improvement
> Reporter: Wenning Ding
> Priority: Major
> Labels: pull-request-available
>
> As discussed with Vinoth, we can rename DataSourceOptions, from xxx_OPT_KEY
> to xxx_OPT.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
