[
https://issues.apache.org/jira/browse/HUDI-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392421#comment-17392421
]
ASF GitHub Bot commented on HUDI-2233:
--------------------------------------
nsivabalan commented on a change in pull request #3387:
URL: https://github.com/apache/hudi/pull/3387#discussion_r681938258
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala
##########
@@ -399,6 +400,11 @@ object DataSourceWriteOptions {
.defaultValue(1000)
.withDocumentation("The number of partitions one batch when synchronous
partitions to hive.")
+ val HIVE_SYNC_MODE: ConfigProperty[String] = ConfigProperty
+ .key("hoodie.datasource.hive_sync.mode")
+ .noDefaultValue()
Review comment:
Also, can we introduce an ENUM for diff modes.
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala
##########
@@ -399,6 +400,11 @@ object DataSourceWriteOptions {
.defaultValue(1000)
.withDocumentation("The number of partitions one batch when synchronous
partitions to hive.")
+ val HIVE_SYNC_MODE: ConfigProperty[String] = ConfigProperty
+ .key("hoodie.datasource.hive_sync.mode")
+ .noDefaultValue()
Review comment:
wondering if we can set jdbc as default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> [SQL] Hive sync is not working
> ------------------------------
>
> Key: HUDI-2233
> URL: https://issues.apache.org/jira/browse/HUDI-2233
> Project: Apache Hudi
> Issue Type: Sub-task
> Reporter: Sagar Sumit
> Assignee: pengzhiwei
> Priority: Major
> Labels: pull-request-available, release-blocker
> Fix For: 0.9.0
>
>
>
> {code:java}
> java.lang.NoClassDefFoundError: org/apache/calcite/rel/type/RelDataTypeSystem
> at
> org.apache.hadoop.hive.ql.parse.SemanticAnalyzerFactory.get(SemanticAnalyzerFactory.java:318)
> at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:484) at
> org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1317) at
> org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1457) at
> org.apache.hadoop.hive.ql.Driver.run(Driver.java:1237) at
> org.apache.hadoop.hive.ql.Driver.run(Driver.java:1227) at
> org.apache.hudi.hive.HoodieHiveClient.updateHiveSQLs(HoodieHiveClient.java:458)
> at
> org.apache.hudi.hive.HoodieHiveClient.updateHiveSQLUsingHiveDriver(HoodieHiveClient.java:448)
> at
> org.apache.hudi.hive.HoodieHiveClient.updateHiveSQL(HoodieHiveClient.java:426)
> at
> org.apache.hudi.hive.HoodieHiveClient.createTable(HoodieHiveClient.java:322)
> at org.apache.hudi.hive.HiveSyncTool.syncSchema(HiveSyncTool.java:230)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)