nsivabalan commented on pull request #3387:
URL: https://github.com/apache/hudi/pull/3387#issuecomment-892775157
my bad. I checked out the master. I did not realize we had sync mode even
before this patch. Ignore my previous question. I see this code block.
```
if (!StringUtils.isNullOrEmpty(cfg.syncMode)) {
switch (cfg.syncMode.toLowerCase()) {
case "hms":
ddlExecutor = new HMSDDLExecutor(configuration, cfg, fs);
break;
case "hiveql":
ddlExecutor = new HiveQueryDDLExecutor(cfg, fs, configuration);
break;
case "jdbc":
ddlExecutor = new JDBCExecutor(cfg, fs);
break;
default:
throw new HoodieHiveSyncException("Invalid sync mode given " +
cfg.syncMode);
}
} else {
ddlExecutor = cfg.useJdbc ? new JDBCExecutor(cfg, fs) : new
HiveQueryDDLExecutor(cfg, fs, configuration);
}
```
So, basically hive sync mode has higher precedence. If not set, we will look
into useJdbc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
