nsivabalan commented on a change in pull request #3387:
URL: https://github.com/apache/hudi/pull/3387#discussion_r682577407
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala
##########
@@ -399,6 +400,11 @@ object DataSourceWriteOptions {
.defaultValue(1000)
.withDocumentation("The number of partitions one batch when synchronous
partitions to hive.")
+ val HIVE_SYNC_MODE: ConfigProperty[String] = ConfigProperty
+ .key("hoodie.datasource.hive_sync.mode")
+ .noDefaultValue()
Review comment:
what I meant, is lets make jdbc as default (since it spans spark
datasource, spark-sql etc). From within spark-sql, may be we can make hms as
default(if user does not explicitly set it)
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala
##########
@@ -399,6 +400,11 @@ object DataSourceWriteOptions {
.defaultValue(1000)
.withDocumentation("The number of partitions one batch when synchronous
partitions to hive.")
+ val HIVE_SYNC_MODE: ConfigProperty[String] = ConfigProperty
+ .key("hoodie.datasource.hive_sync.mode")
+ .noDefaultValue()
Review comment:
what I meant is, lets make jdbc as default (since it spans spark
datasource, spark-sql etc). From within spark-sql, may be we can make hms as
default(if user does not explicitly set it)
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/HiveSyncMode.java
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hive.ddl;
+
+import java.util.Locale;
+
+public enum HiveSyncMode {
+ HMS, HIVEQL, JDBC;
Review comment:
java docs please
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala
##########
@@ -399,6 +400,11 @@ object DataSourceWriteOptions {
.defaultValue(1000)
.withDocumentation("The number of partitions one batch when synchronous
partitions to hive.")
+ val HIVE_SYNC_MODE: ConfigProperty[String] = ConfigProperty
+ .key("hoodie.datasource.hive_sync.mode")
+ .noDefaultValue()
Review comment:
sounds good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
