xiarixiaoyao commented on a change in pull request #3330:
URL: https://github.com/apache/hudi/pull/3330#discussion_r684726567



##########
File path: 
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/cluster/SparkExecuteClusteringCommitActionExecutor.java
##########
@@ -108,8 +108,12 @@ public 
SparkExecuteClusteringCommitActionExecutor(HoodieEngineContext context,
     validateWriteResult(writeMetadata);
     commitOnAutoCommit(writeMetadata);
     if (!writeMetadata.getCommitMetadata().isPresent()) {
+      WriteOperationType realOperationType = operationType;
+      if 
(config.getClusteringExecutionStrategyClass().equals("org.apache.hudi.clustering.SparkOptimizeDataLayoutStrategy"))
 {

Review comment:
       i donnot suggest delete SparkOptimizeWriteCommitActionExecutor.   this 
operation is more flexible than cluster operation, we can optimize table by 
zorder/hilbert by dataFrame api directly and specify some conditions。  of 
course if you insist, i will delete  OPTIMIZE operation




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to