nsivabalan commented on a change in pull request #3401:
URL: https://github.com/apache/hudi/pull/3401#discussion_r685189688
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithLatestAvroPayload.java
##########
@@ -47,10 +47,14 @@ public OverwriteWithLatestAvroPayload(Option<GenericRecord>
record) {
}
@Override
- public OverwriteWithLatestAvroPayload
preCombine(OverwriteWithLatestAvroPayload another) {
+ public OverwriteWithLatestAvroPayload
preCombine(OverwriteWithLatestAvroPayload oldValue) {
// pick the payload with greatest ordering value
- if (another.orderingVal.compareTo(orderingVal) > 0) {
- return another;
+ if (oldValue.recordBytes.length == 0) {
+ // use natural order for delete record
+ return this;
+ }
+ if (oldValue.orderingVal.compareTo(orderingVal) > 0) {
Review comment:
nit: can you move the comment "// pick the payload with greatest
ordering value" to line 56 ish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
