[
https://issues.apache.org/jira/browse/HUDI-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396773#comment-17396773
]
ASF GitHub Bot commented on HUDI-2292:
--------------------------------------
minihippo opened a new pull request #3443:
URL: https://github.com/apache/hudi/pull/3443
## What is the purpose of the pull request
Fix the bug that MOR support predicate pushdown when using payload_combine
merge type.
When reading MOR, predicate pushdown filters the part data in base file
first before combining the log file. The log file record which has the same key
with the dropped record in base file can be obtained if it meets the filter
conditions. But sometimes record in log is out of date by comparing the
precombine column. For example, record has three columns: `key`, `ts`, `col`.
`ts` is precombine field. `key` is record key field .
record1 in log: [k1, ts0, 0]
record2 in base file: [k1, ts1, 1] and ts1 > ts0.
Without filter condition, we will get the record2. But when the filter
condition is `col < 1`, we will get the record1 and it is wrong.
## Brief change log
- set a empty filter when read with payload_combine merge type in
MergeOnReadRelation
## Verify this pull request
- Add this case to `testPrunedFiltered` in `TestMORDataSource`
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> MOR not support predicate pushdown when reading with payload_combine type
> -------------------------------------------------------------------------
>
> Key: HUDI-2292
> URL: https://issues.apache.org/jira/browse/HUDI-2292
> Project: Apache Hudi
> Issue Type: Bug
> Reporter: XiaoyuGeng
> Assignee: XiaoyuGeng
> Priority: Critical
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
