[
https://issues.apache.org/jira/browse/HUDI-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396866#comment-17396866
]
ASF GitHub Bot commented on HUDI-2281:
--------------------------------------
vinothchandar commented on a change in pull request #3417:
URL: https://github.com/apache/hudi/pull/3417#discussion_r686281485
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieSnapshotMetadataClient.java
##########
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.common.table;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hudi.common.table.timeline.HoodieInstant;
+import org.apache.hudi.common.table.view.HoodieTableFileSystemView;
+import org.apache.hudi.common.util.Option;
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+import java.io.IOException;
+import java.util.stream.Stream;
+
+/**
+ * Provides an API for reading metadata
+ * 1) for latest commit.
+ * 2) as of given commit.
+ *
+ * This only includes base files (parquet) today. But can be extended to
return other metadata information.
+ */
+public class HoodieSnapshotMetadataClient {
Review comment:
do we really need two classes? can we just have a single
`HoodieMetadata` class with both functionality?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> add metadata client to read snapshot and incremental information
> ----------------------------------------------------------------
>
> Key: HUDI-2281
> URL: https://issues.apache.org/jira/browse/HUDI-2281
> Project: Apache Hudi
> Issue Type: New Feature
> Reporter: satish
> Assignee: satish
> Priority: Major
> Labels: pull-request-available
>
> We have usecases to
>
> * get all modified partitions since a specified commit time
> * get all data files written as part of latest commit
>
> Provide more high level generic API so different consumers can build on top
> of these interfaces
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
