prashantwason commented on a change in pull request #3210:
URL: https://github.com/apache/hudi/pull/3210#discussion_r686568347
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -137,6 +138,14 @@ protected HoodieBackedTableMetadataWriter(Configuration
hadoopConf, HoodieWriteC
private HoodieWriteConfig createMetadataWriteConfig(HoodieWriteConfig
writeConfig) {
int parallelism = writeConfig.getMetadataInsertParallelism();
+ // The metadata table timeline should always encompass the dataset
timeline so that syncing of manual rollbacks can
+ // always check whether the rolled-back-instant was ever synced to the
metadata table. Since all actions on the
+ // dataset always lead to a delta-commit on the Metadata Table, we need to
preserve enough deltacommits that can
+ // cover total number of all the non-archived actions on the dataset.
+ int multiplier = HoodieTimeline.VALID_ACTIONS_IN_TIMELINE.length;
Review comment:
Remove this as this was leading to too many instants retained on
metadata table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
