[
https://issues.apache.org/jira/browse/HUDI-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17397118#comment-17397118
]
ASF GitHub Bot commented on HUDI-2119:
--------------------------------------
prashantwason commented on a change in pull request #3210:
URL: https://github.com/apache/hudi/pull/3210#discussion_r686568347
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -137,6 +138,14 @@ protected HoodieBackedTableMetadataWriter(Configuration
hadoopConf, HoodieWriteC
private HoodieWriteConfig createMetadataWriteConfig(HoodieWriteConfig
writeConfig) {
int parallelism = writeConfig.getMetadataInsertParallelism();
+ // The metadata table timeline should always encompass the dataset
timeline so that syncing of manual rollbacks can
+ // always check whether the rolled-back-instant was ever synced to the
metadata table. Since all actions on the
+ // dataset always lead to a delta-commit on the Metadata Table, we need to
preserve enough deltacommits that can
+ // cover total number of all the non-archived actions on the dataset.
+ int multiplier = HoodieTimeline.VALID_ACTIONS_IN_TIMELINE.length;
Review comment:
Remove this as this was leading to too many instants retained on
metadata table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Syncing of rollbacks to metadata table does not work in all cases
> -----------------------------------------------------------------
>
> Key: HUDI-2119
> URL: https://issues.apache.org/jira/browse/HUDI-2119
> Project: Apache Hudi
> Issue Type: Bug
> Reporter: Prashant Wason
> Assignee: Prashant Wason
> Priority: Blocker
> Labels: pull-request-available, release-blocker
> Fix For: 0.9.0
>
>
> This is an issue with inline automatic rollbacks.
> Metadata table assumes that a rollbacks is to be applied if the
> instant-being-rolled back has a timestamp less than the last deltacommit time
> on the metadata timeline. We do not explicitly check if the
> instant-being-rolled-back was actually written to metadata table.
> **A rollback adds a record to metadata table which "deletes" files from a
> failed/earlier commit. If the files being deleted were never actually
> committed to metadata table earlier, the deletes cannot be consolidated
> during metadata table reads. This leads to a HoodieMetadataException as we
> cannot differentiate this from a bug where we might have missed committing a
> commit to metadata table.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
