vinothchandar commented on a change in pull request #3210:
URL: https://github.com/apache/hudi/pull/3210#discussion_r687428759
##########
File path:
hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java
##########
@@ -344,8 +326,18 @@ protected HoodieEngineContext getEngineContext() {
return engineContext != null ? engineContext : new
HoodieLocalEngineContext(hadoopConf.get());
}
+ public HoodieMetadataConfig getMetadataConfig() {
+ return metadataConfig;
+ }
+
protected String getLatestDatasetInstantTime() {
return
datasetMetaClient.getActiveTimeline().filterCompletedInstants().lastInstant()
.map(HoodieInstant::getTimestamp).orElse(SOLO_COMMIT_TIMESTAMP);
}
+
+ @Override
+ public Option<String> getSyncedInstantTimeForReader() {
+ return
Option.ofNullable(timelineMergedMetadata).map(TimelineMergedTableMetadata::getSyncedInstantTime());
Review comment:
`TimelineMergedTableMetadata::getSyncedInstantTime` to get past compile
issues. but still `getSyncedInstantTime()`, returns a option by itself. So, may
be we need to indeed go back to the following?
```
@Override
public Option<String> getSyncedInstantTimeForReader() {
if (timelineMergedMetadata == null) {
return Option.empty();
}
return timelineMergedMetadata.getSyncedInstantTime();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
