codope commented on a change in pull request #3433: URL: https://github.com/apache/hudi/pull/3433#discussion_r688264818
########## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/CloudObjectsMetaSelector.java ########## @@ -0,0 +1,208 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.utilities.sources.helpers; + +import com.amazonaws.services.sqs.AmazonSQS; +import com.amazonaws.services.sqs.model.Message; +import com.amazonaws.services.sqs.model.ReceiveMessageRequest; +import com.fasterxml.jackson.databind.ObjectMapper; +import java.io.IOException; +import java.time.Instant; +import java.time.format.DateTimeFormatter; +import java.util.ArrayList; +import java.util.Comparator; +import java.util.Date; +import java.util.List; +import java.util.Map; +import org.apache.hudi.common.config.TypedProperties; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.common.util.ReflectionUtils; +import org.apache.hudi.common.util.collection.ImmutablePair; +import org.apache.hudi.common.util.collection.Pair; +import org.apache.hudi.exception.HoodieException; +import org.apache.spark.api.java.JavaSparkContext; +import org.json.JSONException; +import org.json.JSONObject; + +/** + * Cloud Objects Meta Selector Class. This class will provide the methods to process the messages + * from queue for CloudObjectsMetaSource. + */ +public class CloudObjectsMetaSelector extends CloudObjectsSelector { + + /** Cloud Objects Meta Selector Class. {@link CloudObjectsSelector} */ + public CloudObjectsMetaSelector(TypedProperties props) { + super(props); + } + + /** + * Factory method for creating custom CloudObjectsMetaSelector. Default selector to use is {@link + * CloudObjectsMetaSelector} + */ + public static CloudObjectsMetaSelector createSourceSelector(TypedProperties props) { + String sourceSelectorClass = + props.getString( + CloudObjectsMetaSelector.Config.SOURCE_INPUT_SELECTOR, + CloudObjectsMetaSelector.class.getName()); + try { + CloudObjectsMetaSelector selector = + (CloudObjectsMetaSelector) + ReflectionUtils.loadClass( + sourceSelectorClass, new Class<?>[] {TypedProperties.class}, props); + + log.info("Using path selector " + selector.getClass().getName()); + return selector; + } catch (Exception e) { + throw new HoodieException("Could not load source selector class " + sourceSelectorClass, e); + } + } + + /** + * List messages from queue, filter out illegible events while doing so. It will also delete the + * ineligible messages from queue. + * + * @param processedMessages array of processed messages to add more messages + * @return the list of eligible records + */ + protected List<Map<String, Object>> getEligibleEvents( Review comment: Makes sense. Going with validEvents as records sounds too generic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
