[
https://issues.apache.org/jira/browse/HUDI-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399007#comment-17399007
]
ASF GitHub Bot commented on HUDI-2305:
--------------------------------------
yihua commented on a change in pull request #3472:
URL: https://github.com/apache/hudi/pull/3472#discussion_r688844613
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/rollback/SparkMarkerBasedRollbackStrategy.java
##########
@@ -91,4 +97,37 @@ public SparkMarkerBasedRollbackStrategy(HoodieTable<T,
JavaRDD<HoodieRecord<T>>,
FSUtils.getPartitionPath(config.getBasePath(), partitionPathStr),
fileId, HoodieFileFormat.HOODIE_LOG.getFileExtension(), baseCommitTime)
.collect(Collectors.toMap(HoodieLogFile::getFileStatus, value ->
value.getFileStatus().getLen()));
}
+
+ /**
+ * Gets all marker paths.
+ *
+ * @param instant instant of interest to rollback
+ * @param parallelism parallelism to use
+ * @return a list of all markers
+ * @throws IOException
+ */
+ private List<String> getAllMarkerPaths(String instant, int parallelism)
throws IOException {
+ String markerDir = table.getMetaClient().getMarkerFolderPath(instant);
+ FileSystem fileSystem = FSUtils.getFs(markerDir,
context.getHadoopConf().newCopy());
Review comment:
Right. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix marker-based rollback in 0.9.0
> ----------------------------------
>
> Key: HUDI-2305
> URL: https://issues.apache.org/jira/browse/HUDI-2305
> Project: Apache Hudi
> Issue Type: Bug
> Components: Writer Core
> Reporter: Ethan Guo
> Assignee: Ethan Guo
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
