nsivabalan commented on a change in pull request #3470:
URL: https://github.com/apache/hudi/pull/3470#discussion_r688930663
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/util/MarkerUtils.java
##########
@@ -216,4 +216,4 @@ public static void deleteMarkerTypeFile(FileSystem
fileSystem, String markerDir)
throw new HoodieIOException(ioe.getMessage(), ioe);
}
}
-}
+}
Review comment:
Comment about L186.
I see we filter for entire file path when filtering for MARKERS.*.
shouldn't we fetch just filename and then do filtering? what incase basepath
has "MARKERS" string in them?
I fixed this in TwoToOneDowngrade recreation when we delete the timeline
based markers.
```
Predicate<FileStatus> prefixFilter = pathStr ->
pathStr.getPath().getName().contains(MARKERS_FILENAME_PREFIX);
List<String> markerDirSubPaths = Arrays.stream(fileStatuses)
.filter(prefixFilter)
.map(fileStatus -> fileStatus.getPath().toString())
.collect(Collectors.toList());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
