umehrot2 commented on pull request #3491: URL: https://github.com/apache/hudi/pull/3491#issuecomment-901756554
> @umehrot2 Thanks for the additional fix! > One thing I noticed is that the `DataSourceWriteOptions.KEYGENERATOR_CLASS` has a default value but `HoodieWriteConfig.KEYGENERATOR_CLASS` doesn't. I think we should have the same default values at both places if it's not intentional. @codope good catch. I checked the history, and seems like it was done intentionally https://github.com/apache/hudi/pull/2993#discussion_r642188609 . @nsivabalan can confirm since he reviewed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
