leesf commented on a change in pull request #3534:
URL: https://github.com/apache/hudi/pull/3534#discussion_r695793385
##########
File path:
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/InsertIntoHoodieTableCommand.scala
##########
@@ -193,15 +193,16 @@ object InsertIntoHoodieTableCommand extends Logging {
s"[${insertPartitions.keys.mkString(" " )}]" +
s" not equal to the defined partition in
table[${table.partitionColumnNames.mkString(",")}]")
}
- val parameters = withSparkConf(sparkSession, table.storage.properties)()
++ extraOptions
+ val options = table.storage.properties ++ extraOptions
Review comment:
is the current UTs cover the case (merge into using CTAS)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
