[
https://issues.apache.org/jira/browse/HUDI-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408220#comment-17408220
]
ASF GitHub Bot commented on HUDI-2380:
--------------------------------------
vinothchandar commented on a change in pull request #3568:
URL: https://github.com/apache/hudi/pull/3568#discussion_r700303110
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
##########
@@ -227,11 +227,7 @@ public String
getBootstrapIndexByFileIdFolderNameFolderPath() {
*/
public String getArchivePath() {
String archiveFolder = tableConfig.getArchivelogFolder();
- if
(archiveFolder.equals(HoodieTableConfig.ARCHIVELOG_FOLDER.defaultValue())) {
Review comment:
@danny0405 this is more of a debt due to how we did this at uber
originally. Since HDFS supports append, we started writing out these archived
logs into a single log file (with rollover) under `.hoodie` itself. But on
cloud storage, there is no append and it leads to explosion of small files. So
we moved it to the `.archived` subfolder. My take would be leave this alone
here and override it at the higher layers like cli, spark, flink for backwards
compat reasons. No other reasons.
cc @n3nash , do you have a preference ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> The default archive folder should be 'archived'
> -----------------------------------------------
>
> Key: HUDI-2380
> URL: https://issues.apache.org/jira/browse/HUDI-2380
> Project: Apache Hudi
> Issue Type: Bug
> Components: Common Core
> Reporter: Danny Chen
> Assignee: Danny Chen
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.10.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
