[
https://issues.apache.org/jira/browse/HUDI-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409562#comment-17409562
]
ASF GitHub Bot commented on HUDI-2395:
--------------------------------------
nsivabalan commented on a change in pull request #3595:
URL: https://github.com/apache/hudi/pull/3595#discussion_r701975575
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java
##########
@@ -1261,17 +1532,190 @@ private void validateMetadata(SparkRDDWriteClient
testClient) throws IOException
LOG.info("Validation time=" + timer.endTimer());
}
+ /**
+ * Validate the metadata tables contents to ensure it matches what is on the
file system.
+ */
+ private void validateMetadata(HoodieTestTable testTable, HoodieWriteConfig
config, HoodieEngineContext hoodieEngineContext) throws IOException {
+ validateMetadata(testTable, config, hoodieEngineContext,
Collections.emptyList());
+ }
+
+ /**
+ * Validate the metadata tables contents to ensure it matches what is on the
file system.
+ */
+ private void validateMetadata(HoodieTestTable testTable, HoodieWriteConfig
config, HoodieEngineContext hoodieEngineContext,
Review comment:
Note to Reviewer: This is an almost replica of existing ValidateMetadata
except that this uses HoodieTestTable as source table for validation. As
mentioned in the description, will be adding more tests and eventually will
remove direct SparkRDDClient based tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Make metadata tests lean and consistent
> ---------------------------------------
>
> Key: HUDI-2395
> URL: https://issues.apache.org/jira/browse/HUDI-2395
> Project: Apache Hudi
> Issue Type: Sub-task
> Components: Testing
> Reporter: sivabalan narayanan
> Priority: Major
> Labels: pull-request-available
>
> Make metadata tests lean and consistent using HoodieTestTable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
