[
https://issues.apache.org/jira/browse/HUDI-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410019#comment-17410019
]
Raymond Xu commented on HUDI-1033:
----------------------------------
[~yanghua] [~hongdongdong] [~vbalaji] [~vinoth]
We're defining some boundaries for different tests
* Unit tests: pure logical tests, with mocking when needed
* Functional tests: need to start local server like spark hive, etc. to test a
higher level function
* Integration tests: full-fledged end-to-end test scenario
Each of the categories has a maven profile defined, for the purpose of split
run in CI.
Though many testcases in the existing codebase are functional tests (like
subclasses of HoodieClientHarness), they are ran as if they are unit tests. We
want to address this as we move forward by pushing out new test harness class
and refactoring.
As for CLI module, we should make all commands' testcases as functional tests,
and one for each command, for reasons
* they do not reach the level of full-fledged end-to-end scenario as the setup
in hoodie-integ-test module
* we should keep integration tests only within hoodie-integ-test module for
better logical separation
Currently TestRepairsCommand and ITTestRepairsCommand both (and like other
commands pairs) extend AbstractShellIntegrationTest which are confusing. And
obviously local Spark instances are created for each test method, which is not
ideal. Therefore I'm planning on taking over the CLI tests consolidation and
conversion to functional tests. Feel free to chime in. Thanks.
> Remove redundant CLI tests
> ---------------------------
>
> Key: HUDI-1033
> URL: https://issues.apache.org/jira/browse/HUDI-1033
> Project: Apache Hudi
> Issue Type: Sub-task
> Components: Testing
> Affects Versions: 0.9.0
> Reporter: Balaji Varadarajan
> Assignee: vinoyang
> Priority: Major
> Fix For: 0.10.0
>
>
> There are some tests like ITTestRepairsCommand vs TestRepairsCommand,
> ITTestCleanerCommand vs TestCleanerCommand. Please consolidate if they are
> redundant.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
