wangxianghu commented on a change in pull request #3627:
URL: https://github.com/apache/hudi/pull/3627#discussion_r705068940
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieMetricsPrometheusConfig.java
##########
@@ -70,7 +70,7 @@
.key(PUSHGATEWAY_PREFIX + ".random.job.name.suffix")
.defaultValue(true)
.sinceVersion("0.6.0")
- .withDocumentation("");
+ .withDocumentation("Pushgateway job name need a random suffix, default
true.");
Review comment:
“Whether the pushgateway name need a random suffix , default true”
might be better ?
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieMetricsPrometheusConfig.java
##########
@@ -58,7 +58,7 @@
.key(PUSHGATEWAY_PREFIX + ".delete.on.shutdown")
.defaultValue(true)
.sinceVersion("0.6.0")
- .withDocumentation("");
+ .withDocumentation("Whether to delete the monitoring information from
pushgateway at the end of the task, default true.");
Review comment:
"Delete the pushgateway info or not when job shutdown, true by default" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
