uncleGen commented on a change in pull request #3630:
URL: https://github.com/apache/hudi/pull/3630#discussion_r705295400
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieHFileRealtimeInputFormat.java
##########
@@ -91,14 +91,14 @@ protected HoodieDefaultTimeline
filterInstantsTimeline(HoodieDefaultTimeline tim
// For e:g _hoodie_record_key would be missing and merge step would
throw exceptions.
// TO fix this, hoodie columns are appended late at the time
record-reader gets built instead of construction
// time.
- HoodieRealtimeInputFormatUtils.cleanProjectionColumnIds(jobConf);
Review comment:
Move `cleanProjectionColumnIds` out of this `if` as
`hive.io.file.readcolumn.ids` could be reset with a wrong value, like ',2,0,1'.
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieParquetRealtimeInputFormat.java
##########
@@ -98,7 +98,6 @@ void addProjectionToJobConf(final RealtimeSplit
realtimeSplit, final JobConf job
// For e:g _hoodie_record_key would be missing and merge step would
throw exceptions.
// TO fix this, hoodie columns are appended late at the time
record-reader gets built instead of construction
// time.
- HoodieRealtimeInputFormatUtils.cleanProjectionColumnIds(jobConf);
Review comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
