xushiyan commented on a change in pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#discussion_r706777459
##########
File path: pom.xml
##########
@@ -1486,6 +1487,16 @@
</activation>
</profile>
+ <profile>
+ <id>isSpark3.0</id>
+<!-- for spark 3.0.x we need override the follow propeprties to package
and run test-->
+ <properties>
+ <spark3.version>3.0.0</spark3.version>
+ <spark.version>${spark3.version}</spark.version>
+ <scalatest.version>3.0.1</scalatest.version>
+ </properties>
+ </profile>
Review comment:
instead of a boolean flag, better be explicit about spark version and
have a maven profile match to it. we can name the profile `-Dspark3.0.x` just
for 3.0.x and keep `-Dspark3` points to the latest supported Spark 3 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
